Skip to content

chore: use browser tools to install chrome for testing #31868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Jun 11, 2025

  • Closes N/A

Additional details

Uses browser tools Chrome for Testing to install the browser vs using the @puppeteer/browsers npm package

Steps to test

How has the user experience changed?

PR Tasks

@MikeMcC399

This comment was marked as resolved.

@AtofStryker
Copy link
Contributor Author

@MikeMcC399 As long as we have chrome linked I think this should solve that issue. I was editing and testing this script on a CircleCI docker runner.
Screenshot 2025-06-11 at 3 09 09 PM

@MikeMcC399

This comment was marked as resolved.

@AtofStryker
Copy link
Contributor Author

@AtofStryker

Adding a link would workaround the issue, however the whole installation of Chrome for Testing that browser-tools has implemented is not really clean and according to Unix standards.

@MikeMcC399 I'm attempting to make it a bit more standard in CircleCI-Public/browser-tools-orb#141 which should clean things up and also add a link. Did you want to give it a review? It's a bit difficult to test but AFAIK it looks to be working properly after manually editing the script on a circle machine 😬

@AtofStryker AtofStryker changed the title chore: use browser tools to install chrome for testing chore(WIP): use browser tools to install chrome for testing Jun 11, 2025
@MikeMcC399

This comment was marked as resolved.

@AtofStryker AtofStryker force-pushed the chore/use_cft_browser_tools branch from 78bf2ab to ae37057 Compare June 12, 2025 15:51
Copy link

cypress bot commented Jun 12, 2025

cypress    Run #63036

Run Properties:  status check passed Passed #63036  •  git commit ae37057c17: chore: use browser tools to install chrome for testing
Project cypress
Branch Review chore/use_cft_browser_tools
Run status status check passed Passed #63036
Run duration 09m 22s
Commit git commit ae37057c17: chore: use browser tools to install chrome for testing
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 694
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 130
View all changes introduced in this branch ↗︎

@jennifer-shehane
Copy link
Member

Should be able to ignore the a11y results job - it's failing due to npm outage

@AtofStryker AtofStryker changed the title chore(WIP): use browser tools to install chrome for testing chore: use browser tools to install chrome for testing Jun 12, 2025
@AtofStryker AtofStryker merged commit d475d20 into develop Jun 12, 2025
90 of 93 checks passed
@AtofStryker AtofStryker deleted the chore/use_cft_browser_tools branch June 12, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants