-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: use browser tools to install chrome for testing #31868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@MikeMcC399 As long as we have |
This comment was marked as resolved.
This comment was marked as resolved.
@MikeMcC399 I'm attempting to make it a bit more standard in CircleCI-Public/browser-tools-orb#141 which should clean things up and also add a link. Did you want to give it a review? It's a bit difficult to test but AFAIK it looks to be working properly after manually editing the script on a circle machine 😬 |
This comment was marked as resolved.
This comment was marked as resolved.
ef8bee2
to
78bf2ab
Compare
78bf2ab
to
ae37057
Compare
cypress
|
Project |
cypress
|
Branch Review |
chore/use_cft_browser_tools
|
Run status |
|
Run duration | 09m 22s |
Commit |
|
Committer | Bill Glesias |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
694
|
|
0
|
|
130
|
View all changes introduced in this branch ↗︎ |
Should be able to ignore the a11y results job - it's failing due to npm outage |
Additional details
Uses browser tools Chrome for Testing to install the browser vs using the
@puppeteer/browsers
npm packageSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?